fix(audio): Normalize 'x-wav' audio format to 'wav' #9017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
reviewed
Nov 5, 2025
TomeHirata
reviewed
Nov 6, 2025
Collaborator
|
Thanks @akshatvishu, can you add a unit test? |
Contributor
Author
|
@TomeHirata Added the unit-test and also I slightly changed the logic and used the removeprefix() instead of the replace() to safely remove only the prefix from audio format strings, preventing unintended replacements if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8996
Description:
The
dspy.Audio.from_file(andfrom_url) method relies on Python'smimetypes.guess_type()to determine the audio format. On some operating systems, this function can return non-standard MIME types, such asaudio/x-wavfor.wavfiles.These non-standard format strings, often prefixed with x- (like
x-wavorx-m4a), are then passed to the LLM API (e.g., OpenAI). This can cause a400 BadRequestError, as the API typically only accepts compliant formats (e.g., wav, m4a).This patch adds a check to
from_file,from_url, and the data URI branch ofencode_audioto normalize these formats by removing any x- prefix, ensuring an API-compliant format is always sent.